Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make selectedView and className props available for Search block #4997

Merged
merged 3 commits into from
Jul 24, 2023

Conversation

danalvrz
Copy link
Contributor

@danalvrz danalvrz commented Jul 20, 2023

Made selectedView and className props available to the SearchBlockView.jsx, following the behavior of Listing Block, to improve styling development.

@netlify
Copy link

netlify bot commented Jul 20, 2023

Deploy Preview for volto canceled.

Name Link
🔨 Latest commit 9032b79
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/64baad405c33380008e4850d

@cypress
Copy link

cypress bot commented Jul 20, 2023

Passing run #6547 ↗︎

0 529 20 0 Flakiness 0

Details:

make className prop available
Project: Volto Commit: 9032b794d6
Status: Passed Duration: 15:22 💡
Started: Jul 21, 2023 4:10 PM Ended: Jul 21, 2023 4:26 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@danalvrz danalvrz marked this pull request as ready for review July 20, 2023 23:35
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danalvrz danalvrz changed the title make selectedView prop available as className for Search block make selectedView and className props available for Search block Jul 21, 2023
@sneridagh sneridagh merged commit 03cd36d into master Jul 24, 2023
37 checks passed
@sneridagh sneridagh deleted the add-view-classname-search-block branch July 24, 2023 07:21
sneridagh added a commit that referenced this pull request Jul 24, 2023
* master: (42 commits)
  make selectedView and className props available for Search block (#4997)
  Release @plone/volto-testing 4.0.0-alpha.0
  Release 17.0.0-alpha.21
  Upgrade to Cypress 12.17.1 (latest) (#4981)
  Image rendering (#3337)
  feat(Url.js): add getFieldURL helper function to get the url value of a field based on its structure (#4731)
  Handle @linkintegrity response with items but no breaches (#4832)
  Release 17.0.0-alpha.20
  Use all the apiExpanders in use, so we perform a single request for getting all the required data. (#4946)
  Fix the condition deciding on listing pagination format so it takes into account container blocks as well (#4978)
  Release 17.0.0-alpha.19
  Fix search block input clear button doesn't reset the search (#4837)
  Add /ok route as an express middleware (#4432)
  handles condition for yearly frequency in recurrence (#4604)
  Remove dangling out of place Guillotina Cypress tests (#4980)
  Update to latest plone.restapi and Plone 6.0.6 (#4979)
  Update browserlist (#4977)
  `Links and references` view via content menu [Add `Links to item` view] (#4787)
  Release 17.0.0-alpha.18
  Toc responsive (#4912)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants