Skip to content

Commit

Permalink
test
Browse files Browse the repository at this point in the history
  • Loading branch information
edublancas committed Sep 18, 2024
1 parent ff9656b commit b6d7fae
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 10 deletions.
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ jobs:
run: |
python -m pip install --upgrade pip
pip install .
pip install "matplotlib<3.7" "numpy<1.24.2"
# check package is importable
python -c "import ploomber_engine"
Expand Down
5 changes: 1 addition & 4 deletions tests/test_execute.py
Original file line number Diff line number Diff line change
Expand Up @@ -369,10 +369,7 @@ def test_execute_notebook_invalid_save_profiling_data(
# seems like we have some shared state, we're getting a plot even though the
# code is only printing the current working directory, the problem is in the line:
# self._shell._get_output()
# this started happening after removing the matplotlib<3.7 pin
@pytest.mark.skip(
reason="skip. this started failing after we removed the matplotlib<3.7 pin"
)
# this happens if we remove the pip install "matplotlib<3.7" "numpy<1.24.2" from ci.yml
def test_execute_notebook_different_cwd(tmp_empty):
# setup
run_dir = Path("run_dir")
Expand Down
3 changes: 0 additions & 3 deletions tests/test_memory_release_nb.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,6 @@ def new_exit(self, exc_type, exc_value, traceback):
return new_exit


@pytest.mark.skip(
reason="skip. this started failing after we removed the matplotlib<3.7 pin"
)
def test_if_memory_leak_within_notebook(path_notebook):
"""
epsilon is an amount of memory that is negligeable with respect
Expand Down
3 changes: 0 additions & 3 deletions tests/test_testing.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@ def edit_nb(cells):
nbformat.write(nb, "nb.ipynb")


@pytest.mark.skip(
reason="skip. this started failing after we removed the matplotlib<3.7 pin"
)
def test_no_outputs(tmp_empty):
make_and_execute_nb(["x = 1", "y = 2"])

Expand Down

0 comments on commit b6d7fae

Please sign in to comment.