provide currencyFormat for Plotly Dash #2932
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit it is now allowed currency formatting by setting the currencyFormat property to True. When currencyFormat is enabled, the currencySymbol property allows you to specify the currency symbol to be used. For example, if the input value is 12345, and currencyFormat = true, currencySymbol = '€' it will be displayed as €12345. Co-authored-by: Afonso Faleiro <afonso.faleiro@tecnico.ulisboa.pt>
gvwilson
changed the title
gvwilson
approved these changes
Sep 3, 2024
| } | ||
| const {currencySymbol} = this.props; | ||
|
|
||
| return `${currencySymbol}${Number(value).toLocaleString()}`; |
There was a problem hiding this comment.
are there cases where the currency symbol comes after the number? Or is that just odd English typography like 15¢ that isn't used for international currencies?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #2329
With this commit it is now allowed currency formatting by setting the currencyFormat property to True only when I have type='number'.
When currencyFormat is enabled, the currencySymbol property allows you to specify the currency symbol to be used.
For example, if the input value is 12345, and currencyFormat = true, currencySymbol = '€' it will be displayed as €12345.
Contributor Checklist