Magma blocks don't work any more

[dktapps]

Issue description

Since the bug fix in cb90e30, magma blocks no longer deal damage when an entity walks over the top of them. This is because the hack that was used to trigger onEntityCollide() is now no longer in effect.

Steps to reproduce the issue

1. walk on magma
2. notice it doesn't damage you

OS and versions

• PocketMine-MP: anything since cb90e30

[Squashhh]

What's it been like since 2018?

[dktapps]

No one cares enough to fix it.

The issue is that we have no mechanism for detecting when an entity is touching the surface of a block. The logic currently in the code was implemented incorrectly.

onEntityInside() (previously poorly named onEntityCollide()) isn't suitable for this, because that's used for entities intersecting with the block. You can't intersect with a magma block because it's a solid cube.