Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The top of blocks are now collided with correctly #4243

Closed
wants to merge 1 commit into from
Closed

The top of blocks are now collided with correctly #4243

wants to merge 1 commit into from

Conversation

jasonw4331
Copy link
Contributor

Introduction

Block collisions for the blocks directly below the player will now take effect when the player is within 3/16 of the block.

Relevant issues

Changes

API changes

N/A

Behavioral changes

N/A

Backwards compatibility

N/A

Follow-up

N/A

Tests

In-game testing shows standing on cactus and magma blocks damages the player.
Standing on trapdoors and half slabs does not damage the player.
Standing on carpets will damage the player, matching vanilla.

@dktapps
Copy link
Member

dktapps commented Jun 4, 2021

please don't put special characters in your branch name; this makes it a pain in the ass to checkout in a bash shell.

This change causes other unexpected behaviour, such as getting set on fire when standing on a block adjacent to the fire.

@dktapps dktapps added Category: Gameplay Related to Minecraft gameplay experience Status: Insufficiently Tested Type: Fix Bug fix, typo fix, or any other fix labels Jun 4, 2021
@jasonw4331
Copy link
Contributor Author

This fix is going to require a more complicated solution... I think I'll attempt it another time 🤔

@jasonw4331 jasonw4331 closed this Jun 4, 2021
@jasonw4331 jasonw4331 added Resolution: Abandoned PR has been abandoned by its author and removed Status: Insufficiently Tested labels Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Gameplay Related to Minecraft gameplay experience Resolution: Abandoned PR has been abandoned by its author Type: Fix Bug fix, typo fix, or any other fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants