Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Magma blocks don't work any more #2041

Open
dktapps opened this issue Feb 19, 2018 · 2 comments · May be fixed by #6347
Open

Magma blocks don't work any more #2041

dktapps opened this issue Feb 19, 2018 · 2 comments · May be fixed by #6347
Assignees
@dktapps
Labels
Category: Gameplay Related to Minecraft gameplay experience Status: Debugged Cause of the bug has been found, but not fixed

Comments

@dktapps
Copy link
Member

dktapps commented Feb 19, 2018

Issue description

Since the bug fix in cb90e30, magma blocks no longer deal damage when an entity walks over the top of them. This is because the hack that was used to trigger onEntityCollide() is now no longer in effect.

Steps to reproduce the issue

  1. walk on magma
  2. notice it doesn't damage you

OS and versions

  • PocketMine-MP: anything since cb90e30
@dktapps dktapps added Category: Gameplay Related to Minecraft gameplay experience Status: Debugged Cause of the bug has been found, but not fixed labels Feb 19, 2018
@dktapps dktapps self-assigned this Feb 19, 2018
@dktapps dktapps mentioned this issue Feb 2, 2019
Open
@dktapps dktapps mentioned this issue Oct 9, 2019
Closed
@jasonw4331 jasonw4331 mentioned this issue Jun 4, 2021
Closed
@dktapps dktapps mentioned this issue Aug 11, 2021
Closed
@IvanCraft623 IvanCraft623 mentioned this issue Dec 27, 2023
Closed
@Squashhh
Copy link

What's it been like since 2018?

@dktapps
Copy link
Member Author

dktapps commented Dec 28, 2023

No one cares enough to fix it.

The issue is that we have no mechanism for detecting when an entity is touching the surface of a block. The logic currently in the code was implemented incorrectly.

onEntityInside() (previously poorly named onEntityCollide()) isn't suitable for this, because that's used for entities intersecting with the block. You can't intersect with a magma block because it's a solid cube.

@Dhaiven Dhaiven linked a pull request May 14, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dktapps dktapps

Labels
Category: Gameplay Related to Minecraft gameplay experience Status: Debugged Cause of the bug has been found, but not fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add onEntityCollide function when entity are above a block Dhaiven/PocketMine-MP
2 participants
@dktapps @Squashhh