Implement Monster Spawner functionality #6187
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShockedPlot7560
added
Category: API
are you sure this is a good idea tho
| use pocketmine\event\Cancellable; | ||
| use pocketmine\event\CancellableTrait; | ||
|
|
||
| class SpawnerAttemptSpawnEvent extends BlockEvent implements Cancellable{ |
There was a problem hiding this comment.
Wouldn't it be possible to change more values? The size, the number? Is it useful ?
There was a problem hiding this comment.
I don't think it makes sense to allow changing those in the event, those can be changed on the spawner block
|
does the author mind if i help with this pr? |
I appreciate any help, feel free to offer suggestions or PR |
Joshy3282
added a commit
to Joshy3282/PocketMine-MP
that referenced
this pull request
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This PR implements the functionality of the Monster Spawner block
Changes
API changes
Added SpawnerAttemptSpawnEvent
Follow-up
TODO: spawn condition check (light level etc.)
TODO: spawnData, spawnPotentials
Tests
Not Tested