Add dynamic build date using time() function in VersionInfo #6473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update introduces a dynamic build date in the VersionInfo class using the time() function, allowing the build date to be set at runtime. This change ensures that the build date is always current without needing manual updates.
|
The server isn't built during runtime. It's built during build time. Please ensure the build time is accurate to a time generated during the build step rather than when the server is ran. |
jasonw4331
added
Category: Core
dktapps
requested changes
Oct 25, 2024
src/VersionInfo.php
Outdated
| @@ -103,4 +104,8 @@ public static function VERSION() : VersionString{ | |||
| } | |||
| return self::$fullVersion; | |||
| } | |||
|
|
|||
| public static function BUILD_DATE() : int { | |||
| return time(); | |||
There was a problem hiding this comment.
It's supposed to be the time the phar was built, not the time the function was called.
This isn't as simple as just adding an extra function.
dktapps
reviewed
Nov 2, 2024
| $pharPath = \Phar::running(false); | ||
| $phar = \Phar::isValidPharFilename($pharPath) ? new \Phar($pharPath) : new \PharData($pharPath); | ||
| $meta = $phar->getMetadata(); | ||
| if (isset($meta["date"])) { |
There was a problem hiding this comment.
This isn't going to magically appear in the phar metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update introduces a dynamic build date in the
VersionInfoclass using thetime()function, allowing the build date to be set at runtime. This change ensures that the build date is always current without needing manual updates.