Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v9] fix!: upgrade reconciler for React 19 #3224

Merged
merged 31 commits into from
Apr 26, 2024
Merged

[v9] fix!: upgrade reconciler for React 19 #3224

merged 31 commits into from
Apr 26, 2024

Conversation

CodyJasonBennett
Copy link
Member

Resolves #3222 by implementing new reconciler hooks and bumping the React peer dep to >=19.

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Mar 27, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9a913a6:

Sandbox Source
example Configuration

@CodyJasonBennett
fix: upgrade scheduler, use stable act
a5d9b8a
@CodyJasonBennett
experiment: remove context bridge to isolate hostcontext issue
2619ee6 
TODO: should be able to recreate in react-nil when we upgrade its reconciler
@CodyJasonBennett CodyJasonBennett mentioned this pull request Mar 28, 2024
Open
@CodyJasonBennett
chore: cleanup
056349a
@CodyJasonBennett
chore: upgrade to canary
f490c2e
@CodyJasonBennett
fix: catch null in commitUpdate from prepareUpdate
c0f291c 
Need to confirm behavior change in 19. Seems like a reconciler regression as before, null would prevent commitUpdate from being reachable.
@CodyJasonBennett
chore(RTTR): update snapshot
bf33941 
Reconciler behavior changed here. Confirm with upstream this is expected.
@CodyJasonBennett
chore: upgrade canary
0e7597f
@CodyJasonBennett
chore: update canary, implement updatePriority tracking
03d7828
@CodyJasonBennett
chore: filter out hostcontext warnings
6f5cdba
@sebmarkbage
Copy link

Other than the context/it-fine thing. Is there anything we can help with here?

@CodyJasonBennett
Copy link
Member Author

@sebmarkbage, I need to get our tests up and running before taking anything upstream, but I'm seeing Expected host context to exist. This error is likely caused by a bug in React. Please file an issue. both here and pmndrs/react-nil#19.

@sebmarkbage
Copy link

That seems to be due to facebook/react#25609

getRootHostContext and getChildHostContext just have to return something other than null now because null is a marker for "missing".

@CodyJasonBennett CodyJasonBennett mentioned this pull request Apr 23, 2024
Closed
@CodyJasonBennett
Copy link
Member Author

I upgraded our master branch which reflects the latest stable release v8, and that's all green now #3239 after meeting with Sebastian Silbermann to discover the removal of prepareUpdate. Still some work to do here for v9, but we're unblocked concerning changes to React.

@CodyJasonBennett CodyJasonBennett merged commit be6cc23 into v9 Apr 26, 2024
2 checks passed
@CodyJasonBennett CodyJasonBennett deleted the fix/upgrade-react19 branch April 26, 2024 03:59
@CodyJasonBennett
Copy link
Member Author

CodyJasonBennett commented Apr 26, 2024 •
edited
Loading

Released in 9.0.0-alpha.3. We'll switch to beta as we stabilize our API over the next week.

This was referenced Apr 28, 2024
Merged
Open
@eps1lon eps1lon mentioned this pull request Jun 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodyJasonBennett @sebmarkbage