Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename D_800A0948 to gLoadedFromFileSelect #1080

Merged
merged 5 commits into from
Jul 15, 2023
Merged

rename D_800A0948 to gLoadedFromFileSelect #1080

merged 5 commits into from
Jul 15, 2023

Conversation

Rainchus
Copy link
Contributor

@Rainchus Rainchus commented Jul 8, 2023

No description provided.

z64a
z64a reviewed Jul 8, 2023
View reviewed changes
src/111f0_len_860.c Outdated Show resolved Hide resolved
ethteck
ethteck requested changes Jul 10, 2023
View reviewed changes
Copy link
Member

@ethteck ethteck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jenkins failed with something on the JP build. Make sure you're renaming across all versions

@ethteck ethteck changed the title name D_800A0948 to gMapLoadFrom name D_800A0948 to gLoadedFromFileSelect Jul 15, 2023
@ethteck ethteck changed the title name D_800A0948 to gLoadedFromFileSelect rename D_800A0948 to gLoadedFromFileSelect Jul 15, 2023
ethteck
ethteck reviewed Jul 15, 2023
View reviewed changes
src/111f0_len_860.c Outdated Show resolved Hide resolved
@ethteck ethteck merged commit c2c5f15 into pmret:main Jul 15, 2023
1 check passed
@ethteck ethteck deleted the main branch July 15, 2023 05:26
@ethteck ethteck restored the main branch July 15, 2023 05:26
@ethteck ethteck deleted the main branch July 15, 2023 05:47
@ethteck ethteck restored the main branch July 15, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethteck ethteck ethteck requested changes

@z64a z64a z64a left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rainchus @ethteck @z64a