Mopping #1090
Merged
Mopping #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subrepo: subdir: "tools/splat" merged: "7869ef2e51" upstream: origin: "https://github.com/ethteck/splat.git" branch: "master" commit: "7869ef2e51" git-subrepo: version: "0.4.5" origin: "https://github.com/ingydotnet/git-subrepo" commit: "aa416e4"
bates64
requested changes
Jul 19, 2023
yeah there is unfortunately. more splat work will be needed, but I plan on incrementally working on it |
pull bot
pushed a commit
to skyhoshi/games-papermario
that referenced
this pull request
Jul 19, 2023
* yaml simplifications * remove unneeded end markers after c files * git subrepo pull --force tools/splat subrepo: subdir: "tools/splat" merged: "7869ef2e51" upstream: origin: "https://github.com/ethteck/splat.git" branch: "master" commit: "7869ef2e51" git-subrepo: version: "0.4.5" origin: "https://github.com/ingydotnet/git-subrepo" commit: "aa416e4" * cleanin * effect_shims.h * PRomment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed many hard-coded rom addresses from the US yaml and updated splat to accommodate the change. I hope to eventually remove more and more hard-coded rom addresses, making it easier for us to make yamls for other versions or augment the US one.
I also changed the effect c files to literally refer to the shim functions they call (without the shim_ prefix). This is accomplished the same way as dead.h is - they're renamed when cpp runs over the file.