icons archive generation #1091
Merged
icons archive generation #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethteck
reviewed
Jul 20, 2023
ethteck
approved these changes
Jul 21, 2023
bates64
reviewed
Jul 22, 2023
| @@ -3460,7 +3460,7 @@ void btl_state_update_player_menu(void) { | |||
| case BTL_SUBSTATE_PLAYER_MENU_CHANGE_MEMBER_1: | |||
| entryIdx = 0; | |||
| for (i = 1; i < ARRAY_COUNT(playerData->partners); i++) { | |||
| s32 partnerId = D_8008EEC0[i]; | |||
| s32 partnerId = PartnerIDFromMenuIndex[i]; | |||
There was a problem hiding this comment.
I'm still not sure about the capital "D" in ID. See https://stackoverflow.com/questions/15526107/acronyms-in-camelcase for discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.