Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up map filenames #1175

Merged
merged 4 commits into from
Mar 24, 2024
Merged

Clean up map filenames #1175

merged 4 commits into from
Mar 24, 2024

Conversation

bates64
Copy link
Member

@bates64 bates64 commented Feb 21, 2024 •
edited
Loading

  • renames map files to not include the map name in the file name, because they're in that directory
  • removes the 0_ 1_ 2_ etc prefix for map filenames because
    • this convention is not used anywhere else
    • it's not interesting or useful to know the order in which they are linked
    • if you really want to know, you can check splat
  • renames *header.c to *settings.c
    • MapHeader was renamed to MapSettings
    • don't want to overload "header"

@bates64
Copy link
Member Author

bates64 commented Feb 21, 2024

I'd also like to change the header file names to be consistent but that's another PR

@bates64 bates64 added the help wanted Extra attention is needed label Mar 24, 2024
@bates64
Copy link
Member Author

bates64 commented Mar 24, 2024 •
edited
Loading

Need help with other versions, should just be a case of porting changes in US splat to others

@ethteck ethteck merged commit c43d15e into main Mar 24, 2024
3 checks passed
@ethteck ethteck deleted the rename-map-files branch March 24, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bates64 @ethteck