Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing typing on TermSet add method #2776

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Fixing typing on TermSet add method #2776

merged 2 commits into from
Sep 6, 2023

Conversation

majkelmichel
Copy link
Contributor

@majkelmichel majkelmichel commented Sep 6, 2023 •
edited
Loading

Category

  • Bug fix?
  • New feature?
  • New sample?
  • Documentation update?

Related Issues

fixes bug mentioned in #2775

What's in this Pull Request?

Corrects typing on add method of _TermSets class to match data returned from SP API.
MS docs reference

@majkelmichel majkelmichel marked this pull request as ready for review September 6, 2023 13:21
@majkelmichel majkelmichel changed the title Fixed typing on TermSet add method Fixeing typing on TermSet add method Sep 6, 2023
@majkelmichel majkelmichel changed the title Fixeing typing on TermSet add method Fixing typing on TermSet add method Sep 6, 2023
@juliemturner
Copy link
Collaborator

Thanks so much!

@juliemturner juliemturner merged commit c6dc7ee into pnp:version-3 Sep 6, 2023
1 check passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@majkelmichel @juliemturner