Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React azure openai api stream updates #4695

Merged
merged 12 commits into from
Feb 10, 2024

Conversation

thechriskent
Copy link
Contributor

  • New sample
  • Bug fix/update
  • Related issues: none

What's in this Pull Request?

Performed the following updates to this already awesome sample:

  • Theme fixes
  • Initial AI Message
  • Enter key handling supports new lines with Shift+Enter
  • AI Responses shown in Markdown
  • Markdown can be toggled on or off
  • Removed spinner and replaced with thinking indicator animation

Node Version

Node version used: v18.18.2

Checklist

  • My pull request affects only ONE sample.
  • My sample builds without any warnings
  • I have updated the README.md file's Version history. For new samples, created a new README.md file matching this template
  • My README.md has at least one static high-resolution screenshot (i.e. not a GIF) located in the assets folder.
  • My README.md contains complete setup instructions, including pre-requisites and permissions required
  • My solution includes a .nvmrc file indicating the version of Node.js

Removed global keydown listener and attached directly to TextBox event
Changed from Ctrl-Enter to send to Enter to send with option to use Shift-Enter for newlines
Moved inline styles to SCSS module
Added support for theme colors (fixes issues with display in dark themes)
Simplified Stack logic
Added some adjustments to padding, avatar size, etc.
Makes it easier to compare/contrast what Markdown support adds
Copy link

github-actions bot commented Feb 8, 2024

Validation failed!

File: samples/react-azure-openai-api-stream/assets/sample.json

Copy link

Validation failed!

File: samples/react-azure-openai-api-stream/assets/sample.json

@hugoabernier hugoabernier merged commit e550779 into main Feb 10, 2024
2 checks passed
@hugoabernier hugoabernier deleted the react-azure-openai-api-stream_updates branch February 10, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants