Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create React Poll Webpart #4826

Merged
merged 4 commits into from
Mar 16, 2024
Merged

Create React Poll Webpart #4826

merged 4 commits into from
Mar 16, 2024

Conversation

Harsh24491
Copy link
Contributor

@Harsh24491 Harsh24491 commented Mar 2, 2024

Create a new webpart React Poll

By submitting this pull request, you agree to the contribution guidelines

If you aren't familiar with how to contribute to open-source repositories using GitHub, or if you find the instructions on this page confusing, sign up for one of our Sharing is Caring events. It's completely free, and we'll guide you through the process.

To submit a pull request with multiple authors, make sure that at least one commit is a co-authored commit by adding a Co-authored-by: trailer to the commit's message. E.g.: Co-authored-by: name <name@example.com>

Put an x in all the items that apply ([x], no spaces between the [, the x, and the ] ), make notes next to any that haven't been addressed.

  • New sample
  • Bug fix/update
  • Related issues: fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

Please describe the changes in this PR. Sample description or details around bugs which are being fixed.

(DELETE THIS PARAGRAPH AFTER READING)

Node Version

(Use node -v to get the version of Node you used to build this sample)

Node version used:

Checklist

This checklist is used to automatically pre-process your pull request; It is meant to help process pull requests in a timely manner, rather than hoops to jump through.

Put an x in all the items that apply ([x], no spaces between the [, the x, and the ] ). Make notes next to any that haven't been addressed.

  • My pull request affects only ONE sample.
  • My sample builds without any warnings
  • I have updated the README.md file's Version history. For new samples, created a new README.md file matching this template
  • My README.md has at least one static high-resolution screenshot (i.e. not a GIF) located in the assets folder.
  • My README.md contains complete setup instructions, including pre-requisites and permissions required
  • My solution includes a .nvmrc file indicating the version of Node.js

Submitter Guidance (DELETE AFTER READING)

Please update this PR information accordingly. We'll use this as part of our release notes in monthly communications.

Pull requests that do not follow this template will be automatically rejected.

Please target your PR to main branch.

Remember that this repository is maintained by community members who volunteer their time to help. Be courteous and patient.

(DELETE THIS SECTION AFTER READING)

Create a new webpart React Poll
@hugoabernier
Copy link
Collaborator

Thanks for this sample. Your readme appears to be missing images (and the assets folder).

You also need to fill the PR template (i.e.: complete the checklist).

@Harsh24491
Copy link
Contributor Author

@hugoabernier, Thanks for update.

Added Assets folder.

@hugoabernier
Copy link
Collaborator

Thanks @Harsh24491 for adding the assets folder.

Would you mind making the following changes?

  • The Poll Answers list does not appear to provide the Option column, which results in the following error when submitting an answer:
    image
  • The Loadder class has a typo and should be named Loader
  • The README.md should provide step-by-step instructions how to set up the poll. Please do not use images only, but provide text instructions.
  • If possible, can you provide an additional preview of the web part that is not animated (as per the README.md template?

Please note that I already fixed a few typos and added a few linting rules. I would appreciate if you could incorporate your changes in your commit.

@Harsh24491
Copy link
Contributor Author

@hugoabernier added/modified solution as mentioned. For 1st issue, not getting this for new site collection also. Can you please validate again?

@hugoabernier hugoabernier merged commit 8174604 into pnp:main Mar 16, 2024
1 check passed
@hugoabernier
Copy link
Collaborator

Thank you for your sample, @Harsh24491! I'll assume that the issue with provisioning the list is mine.

If haven't done so yet, and you'd be interested on showing this great sample in a public community call, please fill in following form and we'll get you scheduled - aka.ms/community/request/demo

Thank you for sharing your sample with others - highly appreciated 👏🥇👩‍💻

@Harsh24491
Copy link
Contributor Author

Thanks @hugoabernier for your guidance. 🙌
Submitted form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants