Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PageCommentsWebPart.ts #4828

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Update PageCommentsWebPart.ts #4828

merged 2 commits into from
Mar 11, 2024

Conversation

wideserg
Copy link
Contributor

  • New sample
  • [ x] Bug fix/update
  • Related issues: fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

this.pageurl must be initialized before building this.pastAtachmentPath

Node Version

v16.13.0

Node version used: v16.13.0

Checklist

  • [ x] My pull request affects only ONE sample.
  • My sample builds without any warnings
  • I have updated the README.md file's Version history. For new samples, created a new README.md file matching this template
  • My README.md has at least one static high-resolution screenshot (i.e. not a GIF) located in the assets folder.
  • My README.md contains complete setup instructions, including pre-requisites and permissions required
  • My solution includes a .nvmrc file indicating the version of Node.js

wideserg and others added 2 commits March 11, 2024 16:45
this.pageurl must be initialized before building pastAtachmentPath
@hugoabernier hugoabernier merged commit 0336f96 into pnp:main Mar 11, 2024
2 checks passed
@hugoabernier
Copy link
Collaborator

hugoabernier commented Mar 11, 2024

Thank you @wideserg ! Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants