Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment pages #219

Merged
merged 27 commits into from
Nov 30, 2024
Merged

Conversation

osherwott
Copy link
Contributor

@osherwott osherwott commented Nov 14, 2024

Feedback taken, and added general environment pages and links to everything except the Pokemon pages, because idk where to put a link in those. Would be nice to have code that automatically tracks what environments affect, like evolutions and dive balls, but that'll have to be done with markdown for now.

If anyone has a better idea for listing them in the main Environments page, feel free to change it. Looks rather bland right now.

Pictures:

image
image
image
image
image
image

@github-actions github-actions bot added the html Adding or editing html files label Nov 14, 2024
@github-actions github-actions bot added the script Adding or editing js files label Nov 14, 2024
@wormania
Copy link
Contributor

It would be more consistent with the rest of the Pokémon Locations/method that the Environments are their own pages (and can be linked to/searched for - also useful for other things which use Environment), which the Pokémon page then links to on the relevant obtain method

Also add a check for region <= GameConstants.MAX_AVAILABLE_REGION so that Hisui is hidden for now

@osherwott osherwott changed the title Environment evo data for pokemon page Environment pages Nov 24, 2024
@github-actions github-actions bot added the markdown Adding or editing markdown from the data folder label Nov 24, 2024
@EatPant2nd
Copy link
Contributor

I like this a lot! Thank you!

@EatPant2nd EatPant2nd merged commit eb78aec into pokeclicker:main Nov 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
html Adding or editing html files markdown Adding or editing markdown from the data folder script Adding or editing js files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants