[Testing] refractor: param update E2E tests as integration tests #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanchriswhite
added
testing
bryanchriswhite
force-pushed
the
issues/799/tests/params
branch
from
1adef81
to
2833b6c
Compare
bryanchriswhite
changed the title
6 tasks
bryanchriswhite
added a commit
that referenced
this pull request
Sep 24, 2024
## Summary - Rename `paramMap` type to `paramAnyMap` to improve readability and avoid local variable name collisions - Add missing parameter update assertion steps - Refactor event waiting E2E helpers ## Depends on - #815 ## Dependents - #820 - #826 ## Issue Mitigates silently failing parameter update steps. - #799 ## Type of change Select one or more from the following: - [ ] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing - [ ] **Documentation**: `make docusaurus_start`; only needed if you make doc changes - [ ] **Unit Tests**: `make go_develop_and_test` - [ ] **LocalNet E2E Tests**: `make test_e2e` - [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [ ] I have tested my changes using the available tooling - [x] I have commented my code - [x] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [ ] I have left TODOs throughout the codebase, if applicable --------- Co-authored-by: Daniel Olshansky <olshansky.daniel@gmail.com>
…rge/integration-app_x_sup-stake-evts * issues/799/refactor/integration-app: fixup! HEAD^ fix: linter errors
… issues/799/tests/params * issues/799/merge/integration-app_x_sup-stake-evts: fixup! HEAD^ fix: linter errors
bryanchriswhite
added a commit
that referenced
this pull request
Sep 24, 2024
## Summary Adds the following events: - `EventSupplierStaked` - `EventSupplierUnbondingBegin` - `EventSupplierUnbondingEnd` ## Depends on - #815 ## Dependents - #826 ## Issue Results in more robust supplier.feature steps. - #799 ## Type of change Select one or more from the following: - [x] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing - [ ] **Documentation**: `make docusaurus_start`; only needed if you make doc changes - [ ] **Unit Tests**: `make go_develop_and_test` - [ ] **LocalNet E2E Tests**: `make test_e2e` - [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [x] I have tested my changes using the available tooling - [x] I have commented my code - [x] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [ ] I have left TODOs throughout the codebase, if applicable --------- Co-authored-by: Daniel Olshansky <olshansky.daniel@gmail.com> Co-authored-by: red-0ne <red-0ne@users.noreply.github.com>
Olshansk
reviewed
Sep 24, 2024
| for _, moduleName := range moduleNames { | ||
| msgType := fmt.Sprintf(poktrollMsgTypeFormat, moduleName, msgName) | ||
| authorization := &authz.GenericAuthorization{Msg: msgType} | ||
| s.RunAuthzGrantMsg(t, granterAddr, granteeAddr, authorization) |
Olshansk
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
@bryanchriswhite Approving this, but please add the necessary TODOs before merging.
Co-authored-by: Daniel Olshansky <olshansky.daniel@gmail.com>
bryanchriswhite
force-pushed
the
issues/799/tests/params
branch
from
f2fd8c8
to
f4945c4
Compare
bryanchriswhite
changed the title
This was referenced Sep 25, 2024
Co-authored-by: Daniel Olshansky <olshansky.daniel@gmail.com>
bryanchriswhite
added a commit
that referenced
this pull request
Sep 25, 2024
…#827) ## Summary - Refactor integration app base app construction to eliminate duplicate DB construction. - Set default params for all poktroll modules, some were omitted. - Expose integration app's pre-generated account iterator for use by integration tests. - Add faucet account to integration app to consolidate funding mechanics for integration tests. - Add authz & bank modules to integration app in preparation for param update test porting/refactoring as integration tests (#826). - Add IntegrationAppSuite & base implementation. ## Dependents - #789 - #826 ## Issue - #799 ## Type of change Select one or more from the following: - [x] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing - [ ] **Documentation**: `make docusaurus_start`; only needed if you make doc changes - [ ] **Unit Tests**: `make go_develop_and_test` - [ ] **LocalNet E2E Tests**: `make test_e2e` - [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [x] I have tested my changes using the available tooling - [x] I have commented my code - [x] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [x] I have left TODOs throughout the codebase, if applicable --------- Co-authored-by: red-0ne <red-0ne@users.noreply.github.com> Co-authored-by: Daniel Olshansky <olshansky.daniel@gmail.com>
… issues/799/tests/params * issues/799/merge/integration-app_x_sup-stake-evts: fix: typo chore: review feedback improvements [Docs][Misc] Add iavl tree diff (#776) [Supplier] feat: add supplier un/stake events (#820) [Testing] refactor: E2E param test helpers (#821) # Conflicts: # tests/integration/tokenomics/relay_mining_integration_test.go
* pokt/main: [Testing] refactor: integration app / feat: add `IntegrationAppSuite` (#827)
bryanchriswhite
changed the base branch from
issues/799/merge/integration-app_x_sup-stake-evts
to
main
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ports the
MsgUpdateParamsandMsgUpdateParamE2E tests to integration tests, improving execution speed and maintainability.Depends on
IntegrationAppSuite#827Dependents
min_stakegateway module param #809Issue
Type of change
Select one or more from the following:
consensus-breakinglabel if so. See [Infra] Automatically add theconsensus-breakinglabel #791 for detailsTesting
make docusaurus_start; only needed if you make doc changesmake go_develop_and_testmake test_e2edevnet-test-e2elabel to the PR.Sanity Checklist