test: skip if the namespace cannot be set up due to permissions or if python3 is too old #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluca
changed the title
|
@mrc0mmand Skip or fail the test if the user doesn't have permission to run it? |
|
Let's not fail please, as it breaks package builds. Hit this issue after uploading the new version to Debian. We skip tests that require privileges in systemd too. |
mrc0mmand
reviewed
Aug 23, 2024
|
Yeah, I think skipping the tests in such case is reasonable. |
On some build systems, like Debian's, the tests do not have permissions to create new namespaces, so skip gracefully in that case Follow-up for 8e17f09
It was added in Python 3.12 which is very recent, so skip gracefully if it is not available, like on the current Debian stable or Ubuntu Jammy https://docs.python.org/3/library/os.html#os.unshare
bluca
force-pushed
the
skip_tests_perms
branch
from
0a826c4
to
ce1f697
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some build systems, like Debian's, the tests do not have permissions to create new namespaces, so skip gracefully in that case
Follow-up for 8e17f09