jsauthority: Bump mozjs to 128 #489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSErrorReport::filename is now a ConstUTF8CharsZ. Invoke c_str() to get the C string.
|
Maybe it's time to drop mozjs? duktape's backend has been available and in use in major distros for a few years now |
|
@bluca Yes, this has been discussed months ago in the Github Discussions and it was mentioned in the message following the last release that 125 is the last release with mozjs. |
|
Hello @xry111, many thanks for your time and this PR. It was decided some time ago (and later mentioned in a message in polkit-devel, following the release) that 125 is the last release with mozjs support. Thank you for taking care of mozjs support in polkit over the years. |
|
So see #494 to drop it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Firefox ESR 128 has been released and GNOME 47 has been updated to use it. Do the same for Polkit.
JSErrorReport::filenameis now aConstUTF8CharsZ. Invokec_str()to get the C string.