Skip to content

Commit

Permalink
Update .release-notes/78.md
Browse files Browse the repository at this point in the history
  • Loading branch information
SeanTAllen authored Apr 2, 2024
1 parent 9b9b9a1 commit 22b6340
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .release-notes/78.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
## Rename upgrade to upgrade_protocol

To allow changing the TCP handler of a running http connection, `Session` specifies a method `upgrade_protocol`, which should be implemented by the concrete classes. The implementation used by the actual http server had an implementation for this feature, but the method was called `upgrade`. As `Session` provides a default implementation for `upgrade_protocol`, this wasn't caught. By renaming the implementation it's now possible to use the new feature to change the handler to a custom handler to handle for example WebSocket connections.
To allow changing the TCP handler of a running HTTP connection, `Session` specifies a method `upgrade_protocol`, which should be implemented by the concrete classes. The implementation used by the actual HTTP server had an implementation for this feature, but the method was called `upgrade`. As `Session` provides a default implementation for `upgrade_protocol`, this wasn't caught. By renaming the implementation it's now possible to use the new feature to change the handler to a custom handler to handle for example WebSocket connections.

0 comments on commit 22b6340

Please sign in to comment.