Rename upgrade to upgrade_protocol

ponylang · Apr 2, 2024 · 2ae18a0 · 2ae18a0
1 parent dde272f
commit 2ae18a0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/.release-notes/78.md b/.release-notes/78.md
@@ -0,0 +1,3 @@
+## Rename upgrade to upgrade_protocol
+
+To allow changing the TCP handler of a running HTTP connection, `Session` specifies a method `upgrade_protocol`, which should be implemented by the concrete classes. The implementation used by the actual HTTP server had an implementation for this feature, but the method was called `upgrade`. As `Session` provides a default implementation for `upgrade_protocol`, this wasn't caught. By renaming the implementation it's now possible to use the new feature to change the handler to a custom handler to handle for example WebSocket connections.
diff --git a/http_server/_server_connection.pony b/http_server/_server_connection.pony
@@ -291,6 +291,6 @@ actor _ServerConnection is (Session & HTTP11RequestHandler)
       dispose()
     end
 
-  be upgrade(notify: TCPConnectionNotify iso) =>
+  be upgrade_protocol(notify: TCPConnectionNotify iso) =>
     _conn.set_notify(consume notify)