Skip to content
This repository has been archived by the owner on May 13, 2020. It is now read-only.

Rename pony-stable to tack #91

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Rename pony-stable to tack #91

wants to merge 2 commits into from

Conversation

SeanTAllen
Copy link
Member

This is a PR I am opening to get the work started on this. So far, it includes changing references to bundle.json to tack.json.

@dipinhora do you have time to add changes to the release process to this PR? are there changes with external services that need to be made? i know the pony-stable forumula will need to be changed.

@SeanTAllen
Copy link
Member Author

I've left the name "bundle" in the code but the file is tack.json given that you can have a "tack bundle" as a term with horses. This seems reasonable. The tack.json file defines your bundle of dependencies. However, I'm also open to saying "no, things like _BundleLocator need to be renamed as its confusing otherwise". If that were the case _TackLocator? That seems slightly od to me as the program itself will be called tack.

Thoughts @jemc?

@jemc
Copy link
Member

jemc commented Nov 2, 2018

Agreed about leaving internal use of the term "bundle".

@SeanTAllen
Copy link
Member Author

@dipinhora do you have time to walk me through the mechanics of the rename for COPR etc?

@dipinhora
Copy link
Contributor

@SeanTAllen I'm not sure I have the answers re: COPR, deb packaging, appimage, etc. I don't know if a rename would be sufficient or if it would be better to create a new package for tack. It's a decision that would need to be made along with some others. Should the old pony-stable packages remain for backwards compatibility (without getting new versions added)? Should the pony-stable package remain and become a virtual package that installs tack after the change? There are likely other things to consider and think through and make decisions about.

Once the decisions regarding the package management considerations to the rename have been figured out and made, I can help with figuring out the technical side of things as time permits if needed (note: I'm not an expert on RPM/DEB/etc packaging and would likely be relying on docs and google to figure things out so asking me may or may not be better than trying to figure things out yourself).

@SeanTAllen
Copy link
Member Author

Rebased onto master.

@SeanTAllen
Copy link
Member Author

CI in GH is a little confused right now.

We have failing tests after the rebase. Someone (probably me) can look into it. I'm going to be figuring out the Windows + @cloudsmith story first.

@SeanTAllen
Copy link
Member Author

I'm going to remove bintray as part of this PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants