-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add site preview via Netlify #214
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }} | ||
run: | | ||
preview_url=$(make --silent -C ./docs netlify | tail -n 1 | tr -d '"') | ||
echo "# 🚀 Site Preview" >> $GITHUB_STEP_SUMMARY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just prints in the CI logs right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renders in the preview summary: https://github.com/posit-dev/posit-sdk-py/actions/runs/9452439576?pr=214
(bottom of page) \
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh nice, that's not bad
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started playing with writing a comment to the PR, but updating existing comments on re-runs ended up taking more effort than it was worth.
Site preview is available on the action summary page: https://github.com/posit-dev/posit-sdk-py/actions/runs/9452439576?pr=214
I initially attempted posting this as a comment to the pull request, but it became far too complicated to update existing comments on subsequent runs.