Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add site preview via Netlify #214

Merged
merged 14 commits into from
Jun 11, 2024
Merged

docs: add site preview via Netlify #214

merged 14 commits into from
Jun 11, 2024

Conversation

tdstein
Copy link
Collaborator

@tdstein tdstein commented Jun 10, 2024

Site preview is available on the action summary page: https://github.com/posit-dev/posit-sdk-py/actions/runs/9452439576?pr=214

I initially attempted posting this as a comment to the pull request, but it became far too complicated to update existing comments on subsequent runs.

Copy link

github-actions bot commented Jun 10, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1018 978 96% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: ac541c7 by action🐍

@tdstein tdstein linked an issue Jun 10, 2024 that may be closed by this pull request
docs/requirements-site.txt Outdated Show resolved Hide resolved
NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }}
run: |
preview_url=$(make --silent -C ./docs netlify | tail -n 1 | tr -d '"')
echo "# 🚀 Site Preview" >> $GITHUB_STEP_SUMMARY
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just prints in the CI logs right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renders in the preview summary: https://github.com/posit-dev/posit-sdk-py/actions/runs/9452439576?pr=214

(bottom of page) \

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice, that's not bad

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started playing with writing a comment to the PR, but updating existing comments on re-runs ended up taking more effort than it was worth.

@tdstein tdstein merged commit f2b7ac4 into main Jun 11, 2024
29 checks passed
@tdstein tdstein deleted the tdstein/200 branch June 11, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation site preview to CI
2 participants