fix: correct type signatures according to pyright #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
tdstein
commented
Aug 27, 2024
Comment on lines
+38
to
+40
| def update(self, *args, **kwargs): | ||
| super().update(*args, **kwargs) | ||
|
|
There was a problem hiding this comment.
@zackverham - this resolves the overload signature issue you encountered.
tdstein
force-pushed
the
tdstein/fix-pyright-update-error
branch
from
d70d717
to
8b3a929
Compare
zackverham
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes errors and warnings issued by Pyright.
The update method is added to the base Resource class, which fixes type-checking issues against MutableMapping.