-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: set line length to 99 #291
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
https://peps.python.org/pep-0008/#maximum-line-length
I prefer a longer line length. For what it's worth, the GitHub diff view side-by-side fits comfortably on my screen at this length. |
@@ -37,7 +37,7 @@ version_file = "src/posit/_version.py" | |||
|
|||
[tool.ruff] | |||
extend-exclude = ["integration/resources"] | |||
line-length = 79 | |||
line-length = 99 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you decide on 99? I need to update neovim with a config like this so that I get a visual when my lines are too long (mostly for doc writing since markdown handles wrapping automatically) but I can't decide on a good global default. The standard terminal width 80 feels too small and I think that would be annoying.
edit: nvm I just read your other comment!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does NeoVim support line wraps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably but I don't actually want the automatic wrapping in most cases because it tends to cause such large diffs when I edit files in repos that don't have any formatting enforcement. I prefer the visual so I can see when I'm editing a line that exceeds the length and I can just fix it while I'm in there for lines that I'm already changing.
The maximum line length recommended in PEP-8 is 99. > Some teams strongly prefer a longer line length. For code maintained exclusively or primarily by a team that can reach agreement on this issue, it is okay to increase the line length limit up to 99 characters, provided that comments and docstrings are still wrapped at 72 characters.
e6fa46d
to
eb477e0
Compare
The maximum line length recommended in PEP-8 is 99.