feat: add find_by method to content #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
zackverham
reviewed
Sep 18, 2024
| client = Client("https://connect.example", "12345") | ||
|
|
||
| # invoke | ||
| content = client.content.find_by(name="does-not-exist") |
There was a problem hiding this comment.
if I tried passing in an invalid keyword arg through the **attributes parameter, would anything bad happen?
There was a problem hiding this comment.
Nothing bad. You just won't get any results.
zackverham
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the find_by method to content. The find_by method is a convenience method for filtering a collection of records by attribute values. All filtering happens client-side. This method can be improved to utilize server-side filtering using query parameters.