chore: don't fail the build for having less than 100 percent coverage #32
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
| @@ -42,4 +42,7 @@ jobs: | |||
| uses: orgoro/coverage@v3.1 | |||
| with: | |||
| coverageFile: coverage.xml | |||
| thresholdAll: 0.8 | |||
There was a problem hiding this comment.
Ha, is not having this line what was producing the Threshold number being 0% on other PRs?
Overall Coverage
| Lines | Covered | Coverage | Threshold | Status |
|---|---|---|---|---|
| 353 | 304 | 86% | 0% | 🟢 |
There was a problem hiding this comment.
Ah maybe so? Turns out it wasn't what was failing the build
There was a problem hiding this comment.
Why doesn't github have 🙃 in the quick reactions???
There was a problem hiding this comment.
make cov-xml passes/fails the build based on .coverage settings. This action is set to run if: always() to capture the report in the GitHub Pull Request overview. They should match, I'm surprised the integration isn't tighter.
Makefile
Outdated
| @@ -31,13 +31,13 @@ clean: | |||
| rm -rf .coverage .mypy_cache .pytest_cache .ruff_cache *.egg-info build dist htmlcov | |||
|
|
|||
| cov: | |||
| $(PYTHON) -m coverage report | |||
| $(PYTHON) -m coverage report --fail-under=80 | |||
There was a problem hiding this comment.
I'm going to move this to .coveragerc.
I chose these numbers arbitrarily, happy to use other numbers, but this seems better than the default of failing the build for having less than 100% line coverage, which
mainalready lacks so everything fails.