Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove dict parent class from Context #335

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

schloerke
Copy link
Collaborator

Squash of relevant #332 to merge to main

Use hasattr to look for `_version` variable

Co-Authored-By: Taylor Steinberg <taylor@steinberg.xyz>
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1746 1609 92% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/posit/connect/context.py 94% 🟢
TOTAL 94% 🟢

updated for commit: 27e80d1 by action🐍

Copy link
Collaborator

@tdstein tdstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for rebasing it!

@schloerke schloerke merged commit 4051bfb into main Nov 14, 2024
34 checks passed
@schloerke schloerke deleted the context-to-non-dict-main branch November 14, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants