docs: Added Dash example. #76
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
| session_token = flask.request.headers.get('Posit-Connect-User-Session-Token') | ||
| credentials_provider = viewer_credentials_provider(user_session_token=session_token) |
There was a problem hiding this comment.
I see a pattern like this in all of the examples, and I wonder if we can wrap this up more. Can we have a single function that detects, or try/excepts, to get the header from the places where shiny/flask/etc. put it? (Tangentially related: #54)
There was a problem hiding this comment.
I've had the same thought. I think that would be a nice addition. We'll need to follow the same pattern we did with pandas to avoid having our SDK depend on each of the frameworks.
try:
import flask
except ImportError:
return NoneIt also varies quite a bit depending on the framework. For flask/fastapi, the headers are on the incoming request object. For shiny it's on the session which is only available in the server block. We'll have to experiment with each of the frameworks more to see what feels like the right interface for this helper.
There was a problem hiding this comment.
For shiny it's on the session which is only available in the server block
Slighly complicated further by the fact that Shiny Express doesn't have a server block. But still, may be worth exploring.
examples/connect/dash/README.md
Outdated
| To publish, make sure `CONNECT_SERVER`, `CONNECT_API_KEY`, `DATABRICKS_HOST`, `DATABRICKS_PATH` have valid values. Then, on a terminal session, enter the following command: | ||
|
|
||
| ```bash | ||
| rsconnect deploy shiny . \ |
There was a problem hiding this comment.
| rsconnect deploy shiny . \ | |
| rsconnect deploy dash . \ |
Should this be dash here?
examples/connect/dash/README.md
Outdated
| The Databricks environment variables only need to be set once, unless a change needs to be made. If the values have not changed, you don’t need to provide them again when you publish updates to the document. | ||
|
|
||
| ``` | ||
| rsconnect deploy shiny . \ |
There was a problem hiding this comment.
| rsconnect deploy shiny . \ | |
| rsconnect deploy dash . \ |
Same as above?
| ## Start the app locally | ||
|
|
||
| ```bash | ||
| python app.py |
There was a problem hiding this comment.
I think we should talk about the required environment variables before we show how to run the app. This fails if the user hasn't set DATABRICKS_HOST and DATABRICKS_PATH in their shell
No description provided.