Track object upload status through a progress bar #697
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened:
RFE:
Convert upload size to the nearest KB/MB/GB, rather than bytes.
During image upload, the size is represented in bytes which can be better represented in KB/MB/GB based on the corresponding object that is being uploaded.
pvsadm/pkg/client/s3client.go
Lines 255 to 261 in ee4d801
if _, ok := r.signMap[off]; ok {
r.read += int64(n)
progress := int(float32(r.read*100) / float32(r.size))
fmt.Printf("\rUploading: Total read(bytes):%d progress:%d%%", r.read, progress)
} else {
r.signMap[off] = struct{}{}
}
This can further be improved by introducing a progress bar:
https://github.com/vbauerster/mpb
Test: