fixed f-string unmatched error in src/sylva/helpers/generic.py

[SpiritGun91]

This error prevented me from running sylva but once fixed it runs fine on my machine. Hope this helps.

[ppfeister]

The single quotes shouldn't be an issue by themselves, at least not theoretically, and it took me a second to spot what you were fixing....... maybe it's a conflict with the inner f-string's single quotes? You would think that those would be fine as they're contained within another f-string

Odd that it was causing you problems but not me.

If you run the original again, would you mind sharing the exact error message here? I'd like to see what the difference may be system to system

(feel free to redact any identifying information)

[SpiritGun91]

Traceback (most recent call last):
File "/home/anthonygil/pentest/sylva/bin/sylva", line 5, in
from sylva.console import interactive
File "/home/anthonygil/pentest/sylva/lib/python3.10/site-packages/sylva/console.py", line 6, in
from .handler import Handler
File "/home/anthonygil/pentest/sylva/lib/python3.10/site-packages/sylva/handler.py", line 7, in
from .collector import Collector
File "/home/anthonygil/pentest/sylva/lib/python3.10/site-packages/sylva/collector.py", line 4, in
from .helpers.generic import ResultDataFrame
File "/home/anthonygil/pentest/sylva/lib/python3.10/site-packages/sylva/helpers/generic.py", line 86
if hashlib.sha256(query.replace(' ', '').lower().encode('utf-8')).hexdigest() in requests.get(url=f'{urlunparse(urlparse(github_maintainer_url)._replace(netloc=f'gist.{tldx(github_maintainer_url).domain}.{tldx(github_maintainer_url).suffix}'))}/{id}/raw').text:
^^^^
SyntaxError: f-string: unmatched '('

[SpiritGun91]

Also my bad idk anything about Conventional Commits format lol.

[ppfeister]

Yup, that's right after the inner single quote. Interesting.

It's beyond me as to why it affects some systems and not others. Let me just validate it real quick and I'll merge it in

[ppfeister]

Also my bad idk anything about Conventional Commits format lol.

No worries!

Something like fix: f-string misquote would be the correct way for CC -- the prefix just makes it easy to to find things in a long list of commits. Not going to cherry pick things though it's fine in my book

[ppfeister]

LGTM! Everything checks out when testing

Appreciate that you not only raised the bug but proposed a fix as well!

[SpiritGun91]

Thnx for the quick reply and the merge!

[ppfeister]

Just if you were curious, I've figured out what the discrepancy was --

You're running Python 3.10 (based on the file path in your paste). Something changed in regards to string interpolation between 3.10 and 3.12, which is what my development environment was built using. After doing a quick pdm use 3.10, the error suddenly appears.

Good catch.

[SpiritGun91]

Makes sense. Apt-get is usually behind with python versions, at least with Ubuntu and Kali in my experience so good fix I guess lol