#973 PHP Web Server Action for built-in app development #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
belisoful
commented
Aug 17, 2023
•
belisoful
commented
- Adds the PHP Dev-Test Web Server Action to serve the application. This has the feature of abiding by the "Quiet" flags at different levels. I haven't seen any other built-in PHP Web Server [Yii, Laravel] do the quiet thing. Minor feature.
- Removed "-" from CLI Text action, it was confusing
- TStdOutWriter. This fopens 'php://stdout' when processing a web page b/c STDOUT is not available.
- Corrected TOutputWriter to write to the output rather than stdout.
- Added README.md text for starting the PHP Web Server Action after installing the application.
- Adds the PHP Dev-Test Web Server Action to serve the application. This has the feature of abiding by the "Quiet" flags at different levels. I haven't seen any other built-in PHP Web Server [Yii, Laravel]. Minor feature. - Removed "-" from CLI Text action, it was confusing - TStdOutWriter. This fopens 'php://stdout' when processing a web page b/c STDOUT is not available. - Corrected TOutputWriter to write to the output rather than stdout. - Added README.md text for starting the PHP Web Server Action after installing the application.
…/Performance Mode
ctrlaltca
reviewed
Aug 19, 2023
|
I sat on this to "bake" for a few weeks to make sure everything needed was included. The quiet options were added because of this integration time. You have no idea how glad I am that you are here to check and validate the code. I appreciate these code reviews immensely. |
- Better documentation for TOutputWriter. - TStdOutWriter removes flush and sets the _stdout var. - TWebServerAction corrects Port var, setAll "null" check, and minor tweak to the CLI help text.
|
my hope is that this PR will help people get started with PRADO much faster. |
specify that it can be turned on only for the built in dev server with the getOnlyDevServer configuration option
|
I think that's it unless you find more. |
ctrlaltca
approved these changes
Aug 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.