Important Fixes #43
Important Fixes #43
Conversation
There was a problem hiding this comment.
Hi @j-signorelli,
not sure what happened here, but this PR did not yet get any feedback. Here are some comments to consider, I hope they help.
Maybe rename the PR to give it a more specific title as well?
| # Patch for su2code/SU2#2353 | ||
| if (TimeIter == 0): | ||
| SU2Driver.Output(TimeIter) | ||
| TimeIter += 1 | ||
| time += deltaT |
There was a problem hiding this comment.
Is su2code/SU2#2353 now converged to this fix, or is more discussion going on?
Maybe link to #42 in the comment, since this provides context for the adapter?
| # Get read and write data IDs | ||
| precice_read = "Temperature" | ||
| precice_write = "Heat-Flux" | ||
| GetFxn = lambda *args: -1*SU2Driver.GetVertexNormalHeatFlux(*args) |
There was a problem hiding this comment.
Does this make an assumption on the direction of the heat flux that we should document somewhere? I am not sure if we even document this for other adapters at the moment, but we should.
| parser.add_option("-c", "--precice-config", dest="precice_config", help="Specify preCICE config file", default="../precice-config.xml") | ||
| parser.add_option("-m", "--precice-mesh", dest="precice_mesh", help="Specify the preCICE mesh name", default="Fluid-Mesh") | ||
| parser.add_option("-r", "--precice-reverse", action="store_true", dest="precice_reverse", help="Include flag to have SU2 write temperature, read heat flux", default=False) | ||
| # Command line options |
There was a problem hiding this comment.
For the whitespace changes, I guess we need an automated formatting solution.
This could happen in a separate PR. Ideally, the conversion to tabs should not happen in this PR either, as these are two different things: it will be a bit difficult to see the fixes in the future.
timeandTimeIterproblems #42