Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyoribogo
approved these changes
Dec 3, 2023
vite.config.ts
Outdated
Comment on lines
15
to
31
| build: { | ||
| rollupOptions: { | ||
| external: (id) => { | ||
| if (id.includes('/node_modules/@mswjs')) { | ||
| return true | ||
| } | ||
| if (id.includes('/src/mocks')) { | ||
| return true | ||
| } | ||
| }, | ||
| manualChunks: (id) => { | ||
| if (id.includes('/node_modules')) { | ||
| return 'third-party-library' | ||
| } | ||
| }, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
효중님!! 이 부분은 제가 저번에도 말씀 드렸지만,
그냥 경고 문구가 나왔다고 옵션을 추가하는 건 아닌 것 같아요! 사실 저희 프로젝트 자체가 그렇게 큰 프로젝트도 아닐 뿐더러 오히려 이 옵션을 제거하면 빌드 시간이 더 짧게 나오기도 하는 걸 알 수 있어요 ! 그래서 저는 나중에 더 깊이 공부하고 이 옵션을 추가하는 게 좋다고 생각합니다!
아니면 효중님이 이걸 추가해서 성능을 높인 부분이 정확히 어떤 건지 알 수 있을까요??!!
There was a problem hiding this comment.
api 은닉은 굿굿! 근데 제가 전 프로젝트에서는 로컬에선 잘 됐는데 배포에 반영됐을 때 제대로 안되는 문제가 있었어요 ㅠ 물론 그건 vercel이었기 때문에 안됐을 건데,, s3는 잘 되겠죠? !!!! 👍🏻 👍🏻 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 구현 내용
..작성중
🚧 참고 사항