Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayamaster
reviewed
Nov 1, 2023
Comment on lines
+4
to
+18
| interface Answer { | ||
| questionId: number | ||
| questionType: string | ||
| answer: string[] | ||
| } | ||
|
|
||
| interface Result { | ||
| reviewerId: number | ||
| answers: Answer[] | ||
| } | ||
|
|
||
| interface Response { | ||
| responseId: number | ||
| results: Result[] | ||
| } |
There was a problem hiding this comment.
interface Response {
responseId: number
results: {
reviewerId: number
answers: {
questionId: number
questionType: string
answer: string[]
}
}
}저는 그냥 한 번에 때려 박는?다고 생각했는데, 대부분 depth가 깊어지면 분리하여 type을 작성할까요??
There was a problem hiding this comment.
뭔가 detph가 깊어지면 분리하는게 필요할 거 같습니다 (너무 복잡해질거 같아서,,depth가 깊어진다면?!)
Comment on lines
+1
to
+5
| export const MY_INFO = { | ||
| id: 1, | ||
| name: '[프론트엔드]김아무개', | ||
| email: 'amugae@naver.com', | ||
| } |
There was a problem hiding this comment.
저는 Dummy 데이터들은 handlers 파일 상단에 정의해두긴 했습니다만, 공통으로 빼는 것도 좋을 것 같습니다!
hayamaster
reviewed
Nov 1, 2023
Comment on lines
+15
to
+18
| interface Response { | ||
| responseId: number | ||
| results: Result[] | ||
| } |
There was a problem hiding this comment.
저는 -Props라고 이름을 붙여줬습니다. editResponseProps처럼요! 어떤 것이 나을까요??
There was a problem hiding this comment.
이거는 컴포넌트가 아니라서 props가 아니지 않나요?!!
khj0426
approved these changes
Nov 2, 2023
| @@ -0,0 +1,29 @@ | |||
| import { rest } from 'msw' | |||
| import { | |||
src/apis/hooks/useGetReviewResult.ts
Outdated
| } | ||
|
|
||
| return useQuery({ | ||
| queryKey: ['/received-reviews', 'result'], |
There was a problem hiding this comment.
쿼리 키로 URL을 집어넣는게 어떨까요?
queryKey:[`/received-reviews/${reviewId}`]
이런형식으로 될 거 같은데 reviewId에 따라 바뀔 필요가 없을까요.?!?!
Comment on lines
+4
to
+18
| interface Answer { | ||
| questionId: number | ||
| questionType: string | ||
| answer: string[] | ||
| } | ||
|
|
||
| interface Result { | ||
| reviewerId: number | ||
| answers: Answer[] | ||
| } | ||
|
|
||
| interface Response { | ||
| responseId: number | ||
| results: Result[] | ||
| } |
There was a problem hiding this comment.
뭔가 detph가 깊어지면 분리하는게 필요할 거 같습니다 (너무 복잡해질거 같아서,,depth가 깊어진다면?!)
Comment on lines
+15
to
+18
| interface Response { | ||
| responseId: number | ||
| results: Result[] | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 제목 지라 티켓명하고 똑같이 바꿔주세요! (브랜치명 XX)
📑 구현 내용
API 명세서 기준, 메인에 해당하는 mock API를 구현했습니다.
각각의 쿼리, 뮤테이션 훅은 아래와 같이 명명했습니다.
useEditResponse: 작성한 응답 수정useGetCreatedReviewuseGetInvitedReviewuseGetReceivedReviewuseGetResponseForm: 리뷰 응답자 리스트와 질문 폼 데이터useGetReviewResult: 나에게 온 리뷰 결과 상세 데이터🚧 참고 사항
dummyData파일에 mock 데이터를 구현했습니다.main파일에mainHandlers를 구현했습니다.훅 사용법은 제 이전 프로젝트 wiki 링크 참고해서 저희한테 맞게끔 규칙 정하면 좋을 거 같습니다!