-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explanation of asterisk for required fields to example forms and documentation #820
Merged
+10
−2
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
0e1cc4a
add asterisk explanation to example forms
joshfarrant 8adbf3e
add asterisk recommendation to docs
joshfarrant a8a1f43
github-actions[bot] Regenerated snapshots
joshfarrant 6aad5af
simplified FormControl validation docs example
joshfarrant 3bbd80c
fix bug where TextInput width would expand to length of validation me…
joshfarrant 18140f5
add asterisk recommendation to docs
joshfarrant 3aef3cc
github-actions[bot] Regenerated snapshots
joshfarrant 2aed209
update variable name
joshfarrant 127844e
update snapshots
joshfarrant 5a6f749
Revert "fix bug where TextInput width would expand to length of valid…
joshfarrant d2a3582
update snapshots
joshfarrant 4d1931b
add fullWidth to validation example
joshfarrant c2b78c1
Revert "simplified FormControl validation docs example"
joshfarrant File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-16 Bytes
(100%)
....spec.ts-snapshots/Visual-Comparison-Testimonial-Testimonial-Avatar-1-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-43 Bytes
(100%)
...ual.spec.ts-snapshots/Visual-Comparison-Testimonial-Testimonial-Duo-1-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+40 Bytes
(100%)
...Visual-Comparison-Testimonial-Testimonial-Large-Highlighted-Portion-1-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-9 Bytes
(100%)
...c.ts-snapshots/Visual-Comparison-Testimonial-Testimonial-Playground-1-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+11 Bytes
(100%)
...al.spec.ts-snapshots/Visual-Comparison-Testimonial-Testimonial-Trio-1-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+3.87 KB
(110%)
...pshots/Visual-Comparison-forms-forms-GitHub-Enterprise-sign-up-form-1-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Could we also update the form example further up the page please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good spot, thanks.
I'd searched for all
<form>
tags but looks like that was missing one. I've wrapped it in one now and made the required change 👍There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @joshfarrant.
@simmonsjenna here's a sample of the required field statement we need Site to add to all form designs going forward. Let us know if you have any further guidance on spacing, positioning or colors. We can fix in a follow up.
Link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rezrah LGTM