Skip to content

Commit

Permalink
upgrade popover-polyfill to latest (#2248)
Browse files Browse the repository at this point in the history
  • Loading branch information
keithamus authored Sep 18, 2023
1 parent d2e0f5e commit 9885a5d
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 16 deletions.
7 changes: 7 additions & 0 deletions .changeset/tiny-crews-kneel.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@primer/view-components': patch
---

Update popover support in older browsers.

<!-- Changed components: Primer::Alpha::ActionMenu, Primer::Alpha::Overlay -->
7 changes: 0 additions & 7 deletions app/components/primer/alpha/overlay.pcss
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,3 @@ anchored-position.not-anchored::backdrop {
display: revert;
}
}

/* This reverts the declaration above for native popover, where `:open` is supported (Chrome 113, Safari TP) */
@supports selector(:open) {
anchored-position[popover]:not(.\:popover-open) {
display: revert;
}
}
14 changes: 7 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"@github/include-fragment-element": "^6.1.1",
"@github/relative-time-element": "^4.0.0",
"@github/tab-container-element": "^3.1.2",
"@oddbird/popover-polyfill": "^0.2.1",
"@oddbird/popover-polyfill": "^0.2.3",
"@primer/behaviors": "^1.3.4"
},
"devDependencies": {
Expand All @@ -63,6 +63,7 @@
"@playwright/test": "^1.35.1",
"@primer/css": "21.0.2",
"@primer/primitives": "7.12.0",
"@primer/stylelint-config": "^12.7.2",
"@rollup/plugin-node-resolve": "^13.3.0",
"@rollup/plugin-typescript": "^8.3.3",
"@typescript-eslint/eslint-plugin": "^5.31.0",
Expand Down Expand Up @@ -90,7 +91,6 @@
"stylelint": "^14.13.0",
"stylelint-config-prettier": "^9.0.3",
"stylelint-config-standard": "^28.0.0",
"@primer/stylelint-config": "^12.7.2",
"tslib": "^2.4.0",
"typescript": "^4.7.4"
},
Expand Down

0 comments on commit 9885a5d

Please sign in to comment.