Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interactive snapshot tests #2139

Merged
merged 7 commits into from
Jul 12, 2023
Merged

Add interactive snapshot tests #2139

merged 7 commits into from
Jul 12, 2023

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Jul 12, 2023

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

Adds an interactive param to Playwright tests so we can open menus/dialogs for screenshots.

Screenshots

Integration

No

List the issues that this change affects.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Anything you want to highlight for special attention from reviewers?

Accessibility

  • Fixes axe scan violation - This change fixes an existing axe scan violation.
  • No new axe scan violation - This change does not introduce any new axe scan violations.
  • New axe violation - This change introduces a new axe scan violation. Please describe why the violation cannot be resolved below.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2023

⚠️ No Changeset found

Latest commit: e0982e9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@langermank langermank temporarily deployed to preview July 12, 2023 17:06 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2023

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@langermank langermank temporarily deployed to preview July 12, 2023 18:22 — with GitHub Actions Inactive
@langermank langermank temporarily deployed to github-pages July 12, 2023 18:26 — with GitHub Actions Inactive
@langermank langermank added the skip changeset Pull requests that don't change the library output label Jul 12, 2023
@langermank langermank marked this pull request as ready for review July 12, 2023 18:33
@langermank langermank requested review from a team and keithamus July 12, 2023 18:33
@langermank langermank merged commit 682fcfe into main Jul 12, 2023
28 of 29 checks passed
@langermank langermank deleted the interactive-snapshots branch July 12, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Pull requests that don't change the library output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants