Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better gem caching for preview deploys #2171

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Conversation

camertron
Copy link
Contributor

@camertron camertron commented Aug 1, 2023

What are you trying to accomplish?

We have three different gemfiles that install gems for 1) the lib, 2) the demo app, and 3) the Kuby deploy. Right now, we're only caching gems for the lib.

Integration

No changes necessary in production.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

This PR adds several additional ruby/setup-ruby steps for the other two gemfiles. Including this action multiple times seems to be ok and takes care of a lot of the difficult minutiae of caching bundles.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

@changeset-bot
Copy link

changeset-bot bot commented Aug 1, 2023

⚠️ No Changeset found

Latest commit: 95d08f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@camertron camertron merged commit 5a6dfcd into main Aug 1, 2023
31 checks passed
@camertron camertron deleted the moar_preview_caching branch August 1, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Pull requests that don't change the library output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants