Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect autofocus attributes inside of a dialog when opening a dialog #2290

Merged
merged 4 commits into from
Oct 18, 2023

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Oct 18, 2023

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

Closes https://github.com/github/primer/issues/2749

The dialog component wasn't respecting autofocus attributes inside of the dialog when it's opened. Instead it was still focusing the close button. This updates to focus autofocus when it exists and still falls back to the close button when it doesn't exist.

Integration

No

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2023

🦋 Changeset detected

Latest commit: 69e3570

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Oct 18, 2023
@jonrohan jonrohan merged commit f33eed3 into main Oct 18, 2023
28 checks passed
@jonrohan jonrohan deleted the autofocus_in_dialog branch October 18, 2023 21:10
@jonrohan jonrohan temporarily deployed to preview October 18, 2023 21:10 — with GitHub Actions Inactive
@primer primer bot mentioned this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants