Action menu prevent scrolling on link click #2331
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This PR prevents scrolling when an
ActionMenu
link item is activated via the<Space>
key. This is a follow-on PR to #2326, which addressed the same issue, but forActionMenu
items that are submit buttons, i.e.<button type="submit">
.Integration
No changes necessary in production.
Risk Assessment
What approach did you choose and why?
It turns out calling
event.preventDefault()
will stop forms from being submitted, but does not affect link navigation. The fix in this PR callsevent.preventDefault()
whenever an item is activated with<Space>
, whereas previouslypreventDefault()
was only called if the item was a submit button.Accessibility
Merge checklist
- [ ] Added/updated tests- [ ] Added/updated documentation- [ ] Added/updated previews (Lookbook)Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.