Action menu prevent scrolling on link click

[camertron]

What are you trying to accomplish?

This PR prevents scrolling when an ActionMenu link item is activated via the <Space> key. This is a follow-on PR to #2326, which addressed the same issue, but for ActionMenu items that are submit buttons, i.e. <button type="submit">.

Integration

No changes necessary in production.

Risk Assessment

• Low risk the change is small, highly observable, and easily rolled back.
• Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
• High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

It turns out calling event.preventDefault() will stop forms from being submitted, but does not affect link navigation. The fix in this PR calls event.preventDefault() whenever an item is activated with <Space>, whereas previously preventDefault() was only called if the item was a submit button.

Accessibility

• No new axe scan violation - This change does not introduce any new axe scan violations.

Merge checklist

- [ ] Added/updated tests
- [ ] Added/updated documentation
- [ ] Added/updated previews (Lookbook)

• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

[changeset-bot]

🦋 Changeset detected

Latest commit: 81b488d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/view-components	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR