-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rails 7.1 support #2336
Add Rails 7.1 support #2336
Conversation
🦋 Changeset detectedLatest commit: 6892d11 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@camertron Removing the I'm experiencing issues with Indeed, by removing |
@safeforge interesting, thanks for the heads-up. Let me see if I can get our test suite to fail, that would really help catch these issues. |
Ok, I totally forgot to bump the framework defaults in the demo app's application.rb. Doing so uncovered several additional bad @safeforge can you verify this addresses the issues you're seeing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
@camertron, I can confirm that your fix has resolved the issue in my use case. Thank you! |
What are you trying to accomplish?
This PR makes the changes necessary to support Rails 7.1.
Integration
No changes necessary in production.
List the issues that this change affects.
Fixes #2318
Risk Assessment
What approach did you choose and why?
The only thing necessary to support Rails 7.1 is to remove an unnecessary
require
statement in the Rails engine. Rails 7.1 no longer adds eager load paths to Ruby's load path, preferring instead to let Zeitwerk autoload missing constants.Accessibility