Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for trailing and leading visual icons in Primer::Beta::Link (second try) #3041

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add support for trailing and leading visual icons in Primer::Beta::Link (second try) #3041

wants to merge 4 commits into from

Commits on Aug 30, 2024

  1. Revert "Revert "Add support for trailing and leading visual icons in … 

    …Primer::Beta::Link (primer#2982)" (primer#3040)"

This reverts commit 612307d.
    @HDinger
    HDinger committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    abfbd54 View commit details
    Browse the repository at this point in the history

  2. Remove duplicated trimmed_content method which is now part of `Prim… 

    …er::Component`
    @HDinger
    HDinger committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    8a63255 View commit details
    Browse the repository at this point in the history

  3. Add additional span inside the link to be able to limit the underline… 

    … effect to the actual text instead of overflowing into the white space between text and leading/trailing icons
    @HDinger
    HDinger committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    80b0d8b View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Add line-height to ensure correct height of link text

    @HDinger
    HDinger committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    44ae1be View commit details
    Browse the repository at this point in the history