-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete revamp #51
Draft
WhyAsh5114
wants to merge
84
commits into
main
Choose a base branch
from
40-relations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Complete revamp #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and a big default model with lots of default fields for testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving to multi-class approach
To support relations, we can't re-use a base class for all the models, at least not with my current TypeScript skills.
Performance issues
Moving to individual classes for each model, this does take up quite some time to generate (~2s) even for small schemas, maybe this is due to using Node to write files, or I wrote terrible code (probably I wrote terrible code), but its something I'm willing to sacrifice for now till the complete API with relations and schema features can be implemented through IDB.
API progress
Model queries
findRaw()aggreagateRaw()Model query options
relationLoadStrategy (Preview)Nested queries
Filter conditions and operators
Relation filters
Scalar list methods
Scalar list filters
Atomic number operations