Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 Zip up produced artifacts #24

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

berkus
Copy link
Contributor

@berkus berkus commented Dec 6, 2024

  • Put everything into a zip file

  • Keep gerbers and drills in their own zip file within the outer zip package

  • Produce the same structure zip file in all pipelines, so you can review what goes into it starting from the PR builds.

@berkus berkus force-pushed the zip-pipeline-artifacts branch from 089b89b to ac862fc Compare December 6, 2024 14:57
@Yatekii
Copy link
Member

Yatekii commented Dec 6, 2024

Why two zips? :) I would prefer just one layer :)

@berkus
Copy link
Contributor Author

berkus commented Dec 6, 2024

@Yatekii ah, sorry, we discussed with Emil that this will be better for JLCPCB, I don't have a preference personally but if it actually makes it easier to submit the files for production that's what I'd choose.

@berkus
Copy link
Contributor Author

berkus commented Dec 6, 2024

@korken89 pls download the Artifact from the bottom of this page https://github.com/probe-rs/rusty-probe/actions/runs/12200986874 and check that it's in a good format.

@korken89
Copy link
Collaborator

korken89 commented Dec 7, 2024

Looks good!

@korken89
Copy link
Collaborator

korken89 commented Dec 7, 2024

@berkus The generate_outputs never run so I can't merge. Do we need to enable something more?

@korken89
Copy link
Collaborator

korken89 commented Dec 7, 2024

Huh, that one does not exist in the repo... I'll check if it's a setting

@korken89 korken89 merged commit 90bdcb0 into probe-rs:master Dec 7, 2024
1 check passed
@berkus
Copy link
Contributor Author

berkus commented Dec 7, 2024

I'll check if it's a setting

I think it was the old step name, but GH doesn't remove it from required checks even if it's gone from the pipelines, security measure.

Need to delete it manually.

@berkus berkus deleted the zip-pipeline-artifacts branch December 7, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants