Skip to content

Commit

Permalink
Merge pull request #8966 from nelljerram/from-as-casing-3.27
Browse files Browse the repository at this point in the history
Fix case of 'AS' in Dockerfile 'FROM' lines
  • Loading branch information
nelljerram committed Jul 2, 2024
2 parents 438fedb + dad0960 commit d3157f6
Show file tree
Hide file tree
Showing 28 changed files with 51 additions and 51 deletions.
2 changes: 1 addition & 1 deletion apiserver/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM scratch as source
FROM scratch AS source

ARG BIN_DIR
ARG TARGETARCH
Expand Down
2 changes: 1 addition & 1 deletion app-policy/Dockerfile.amd64
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
ARG GIT_VERSION=unknown
ARG UBI_IMAGE

FROM ${UBI_IMAGE} as ubi
FROM ${UBI_IMAGE} AS ubi

RUN mkdir -p /tmp/dikastes
RUN chmod 0777 /tmp/dikastes
Expand Down
2 changes: 1 addition & 1 deletion calicoctl/Dockerfile.amd64
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

ARG UBI_IMAGE

FROM ${UBI_IMAGE} as ubi
FROM ${UBI_IMAGE} AS ubi

RUN mkdir /licenses
COPY LICENSE /licenses
Expand Down
4 changes: 2 additions & 2 deletions calicoctl/Dockerfile.arm64
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
ARG QEMU_IMAGE=calico/go-build:v0.55
ARG UBI_IMAGE

FROM ${QEMU_IMAGE} as qemu
FROM ${QEMU_IMAGE} AS qemu

FROM --platform=linux/arm64 ${UBI_IMAGE} as ubi
FROM --platform=linux/arm64 ${UBI_IMAGE} AS ubi

# Enable non-native builds of this image on an amd64 hosts.
# This must be the first RUN command in this file!
Expand Down
2 changes: 1 addition & 1 deletion calicoctl/Dockerfile.armv7
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
ARG QEMU_IMAGE
FROM --platform=linux/arm/v7 ${QEMU_IMAGE} as qemu
FROM --platform=linux/arm/v7 ${QEMU_IMAGE} AS qemu

FROM arm32v7/alpine:3.12
# Enable non-native builds of this image on an amd64 hosts.
Expand Down
2 changes: 1 addition & 1 deletion calicoctl/Dockerfile.ppc64le
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
ARG QEMU_IMAGE
FROM ${QEMU_IMAGE} as qemu
FROM ${QEMU_IMAGE} AS qemu

FROM ppc64le/alpine:3.10
# Enable non-native builds of this image on an amd64 hosts.
Expand Down
2 changes: 1 addition & 1 deletion calicoctl/Dockerfile.s390x
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
ARG QEMU_IMAGE
# Copying qemu binary files from amd64 container.
# latest `go-build` containers got no candidate for `s390x` architecture.
FROM --platform=linux/amd64 ${QEMU_IMAGE} as qemu
FROM --platform=linux/amd64 ${QEMU_IMAGE} AS qemu

FROM s390x/alpine:3.10
# Enable non-native builds of this image on an amd64 hosts.
Expand Down
2 changes: 1 addition & 1 deletion cni-plugin/Dockerfile.amd64
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

ARG UBI_IMAGE

FROM ${UBI_IMAGE} as ubi
FROM ${UBI_IMAGE} AS ubi

FROM scratch

Expand Down
2 changes: 1 addition & 1 deletion cni-plugin/Dockerfile.s390x
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
ARG UBI_IMAGE

FROM ${UBI_IMAGE} as ubi
FROM ${UBI_IMAGE} AS ubi

LABEL maintainer "LoZ Open Source Ecosystem (https://www.ibm.com/developerworks/community/groups/community/lozopensource)"

Expand Down
4 changes: 2 additions & 2 deletions felix/docker-image/Dockerfile.amd64
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@
# This ensures that testing of Felix in this repository is done in the same
# userspace environment as it will be deployed in calico/node.

FROM ubuntu:focal as wgtool
FROM ubuntu:focal AS wgtool

RUN apt-get update && \
apt-get install --no-install-recommends wireguard-tools -y

FROM calico/bpftool:v7.4.0 as bpftool
FROM calico/bpftool:v7.4.0 AS bpftool

FROM debian:10-slim
LABEL maintainer="Shaun Crampton <shaun@tigera.io>"
Expand Down
6 changes: 3 additions & 3 deletions felix/docker-image/Dockerfile.s390x
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
ARG QEMU_IMAGE

FROM ${QEMU_IMAGE} as qemu
FROM s390x/ubuntu:focal as wgtool
FROM ${QEMU_IMAGE} AS qemu
FROM s390x/ubuntu:focal AS wgtool
# Enable non-native builds of this image on an amd64 hosts.
# This must be the first RUN command in this file!
COPY --from=qemu /usr/bin/qemu-*-static /usr/bin/
RUN apt-get update && \
apt-get install --no-install-recommends wireguard-tools -y

FROM calico/bpftool:v5.3-s390x as bpftool
FROM calico/bpftool:v5.3-s390x AS bpftool

FROM s390x/debian:10-slim
LABEL maintainer="Shaun Crampton <shaun@tigera.io>"
Expand Down
2 changes: 1 addition & 1 deletion kube-controllers/Dockerfile.amd64
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
ARG GIT_VERSION=unknown
ARG UBI_IMAGE

FROM ${UBI_IMAGE} as ubi
FROM ${UBI_IMAGE} AS ubi

# Add in top-level license file
RUN mkdir /licenses
Expand Down
4 changes: 2 additions & 2 deletions kube-controllers/Dockerfile.arm64
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
ARG QEMU_IMAGE
ARG UBI_IMAGE

FROM ${QEMU_IMAGE} as qemu
FROM ${QEMU_IMAGE} AS qemu

FROM --platform=linux/arm64 ${UBI_IMAGE} as ubi
FROM --platform=linux/arm64 ${UBI_IMAGE} AS ubi

# Enable non-native builds of this image on an amd64 hosts.
# This must be the first RUN command in this file!
Expand Down
4 changes: 2 additions & 2 deletions kube-controllers/Dockerfile.s390x
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ ARG GIT_VERSION=unknown
ARG UBI_IMAGE
ARG QEMU_IMAGE

FROM ${QEMU_IMAGE} as qemu
FROM ${UBI_IMAGE} as ubi
FROM ${QEMU_IMAGE} AS qemu
FROM ${UBI_IMAGE} AS ubi

COPY --from=qemu /usr/bin/qemu-*-static /usr/bin/

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
ARG GIT_VERSION=unknown
ARG UBI_IMAGE

FROM ${UBI_IMAGE} as ubi
FROM ${UBI_IMAGE} AS ubi

# Add in top-level license file
RUN mkdir /licenses
Expand Down
2 changes: 1 addition & 1 deletion networking-calico/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM quay.io/coreos/etcd:v3.4.20 as etcd
FROM quay.io/coreos/etcd:v3.4.20 AS etcd

FROM python:3.8

Expand Down
8 changes: 4 additions & 4 deletions node/Dockerfile.amd64
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@ ARG RUNIT_VER=2.1.2
ARG BIRD_IMAGE=calico/bird:latest
ARG UBI_IMAGE

FROM calico/bpftool:v7.4.0 as bpftool
FROM ${BIRD_IMAGE} as bird
FROM calico/bpftool:v7.4.0 AS bpftool
FROM ${BIRD_IMAGE} AS bird

# Use this build stage to build iptables rpm and runit binaries.
# We need to rebuild the iptables rpm because the prepackaged rpm does not have legacy iptables binaries.
# We need to build runit because there aren't any rpms for it in AlmaLinux or ubi repositories.
FROM almalinux:8 as almalinux
FROM almalinux:8 AS almalinux

ARG IPTABLES_VER
ARG LIBNFTNL_VER
Expand Down Expand Up @@ -81,7 +81,7 @@ RUN wget -P /tmp https://ftp.debian.org/debian/pool/main/r/runit/runit_${RUNIT_V
cd /tmp/admin/runit-${RUNIT_VER}/ && \
package/install

FROM ${UBI_IMAGE} as ubi
FROM ${UBI_IMAGE} AS ubi

ARG GIT_VERSION
ARG IPTABLES_VER
Expand Down
10 changes: 5 additions & 5 deletions node/Dockerfile.arm64
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@ ARG QEMU_IMAGE
ARG BIRD_IMAGE=calico/bird:latest
ARG UBI_IMAGE

FROM calico/bpftool:v7.4.0 as bpftool
FROM ${QEMU_IMAGE} as qemu
FROM ${BIRD_IMAGE} as bird
FROM calico/bpftool:v7.4.0 AS bpftool
FROM ${QEMU_IMAGE} AS qemu
FROM ${BIRD_IMAGE} AS bird

# Use this build stage to build iptables rpm and runit binaries.
# We need to rebuild the iptables rpm because the prepackaged rpm does not have legacy iptables binaries.
# We need to build runit because there aren't any rpms for it in AlmaLinux or ubi repositories.
FROM almalinux:8 as almalinux
FROM almalinux:8 AS almalinux

# Enable non-native builds of this image on an amd64 hosts.
# This must be the first RUN command in this file!
Expand Down Expand Up @@ -94,7 +94,7 @@ RUN wget -P /tmp https://ftp.debian.org/debian/pool/main/r/runit/runit_${RUNIT_V
sed -i "s/utmpset/\/tmp\/admin\/runit-2.1.2\/compile\/utmpset/" src/utmpset.dist && \
package/install

FROM ${UBI_IMAGE} as ubi
FROM ${UBI_IMAGE} AS ubi

ARG GIT_VERSION
ARG IPTABLES_VER
Expand Down
6 changes: 3 additions & 3 deletions node/Dockerfile.armv7
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@
ARG QEMU_IMAGE=calico/go-build:latest
ARG BIRD_IMAGE=calico/bird:latest

FROM ${QEMU_IMAGE} as qemu
FROM ${BIRD_IMAGE} as bird
FROM ${QEMU_IMAGE} AS qemu
FROM ${BIRD_IMAGE} AS bird

FROM arm32v7/alpine:3.18 as base
FROM arm32v7/alpine:3.18 AS base
MAINTAINER Marc Crébassa <aalaesar@gmail.com>

ARG ARCH=armv7
Expand Down
6 changes: 3 additions & 3 deletions node/Dockerfile.ppc64le
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@
ARG QEMU_IMAGE=calico/go-build:latest
ARG BIRD_IMAGE=calico/bird:latest

FROM ${QEMU_IMAGE} as qemu
FROM ${BIRD_IMAGE} as bird
FROM ${QEMU_IMAGE} AS qemu
FROM ${BIRD_IMAGE} AS bird

FROM calico/bpftool:v7.4.0 as bpftool
FROM calico/bpftool:v7.4.0 AS bpftool

FROM ppc64le/alpine:3.18
MAINTAINER David Wilder <wilder@us.ibm.com>
Expand Down
8 changes: 4 additions & 4 deletions node/Dockerfile.s390x
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@
ARG QEMU_IMAGE=calico/go-build:latest
ARG BIRD_IMAGE

FROM ${QEMU_IMAGE} as qemu
FROM ${BIRD_IMAGE} as bird
FROM ${QEMU_IMAGE} AS qemu
FROM ${BIRD_IMAGE} AS bird

FROM calico/bpftool:v7.4.0 as bpftool
FROM calico/bpftool:v7.4.0 AS bpftool

FROM s390x/alpine:3.18 as base
FROM s390x/alpine:3.18 AS base
# Enable non-native builds of this image on an amd64 hosts.
# This must be the first RUN command in this file!
COPY --from=qemu /usr/bin/qemu-*-static /usr/bin/
Expand Down
2 changes: 1 addition & 1 deletion pod2daemon/Dockerfile.amd64
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

ARG UBI_IMAGE

FROM ${UBI_IMAGE} as ubi
FROM ${UBI_IMAGE} AS ubi

ADD flexvol/docker/clean.sh /usr/local/bin/clean.sh
ADD flexvol/docker/flexvol.sh /usr/local/bin/flexvol.sh
Expand Down
2 changes: 1 addition & 1 deletion pod2daemon/csidriver/Dockerfile.amd64
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
ARG UBI_IMAGE
FROM ${UBI_IMAGE} as ubi
FROM ${UBI_IMAGE} AS ubi

FROM scratch
SHELL ["/bin/sh", "-c"]
Expand Down
2 changes: 1 addition & 1 deletion pod2daemon/node-driver-registrar-docker/Dockerfile.amd64
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
ARG UBI_IMAGE
FROM ${UBI_IMAGE} as ubi
FROM ${UBI_IMAGE} AS ubi

FROM scratch
SHELL ["/bin/sh", "-c"]
Expand Down
2 changes: 1 addition & 1 deletion typha/docker-image/Dockerfile.amd64
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
ARG GIT_VERSION=unknown
ARG UBI_IMAGE

FROM ${UBI_IMAGE} as ubi
FROM ${UBI_IMAGE} AS ubi

# Since our binary isn't designed to run as PID 1, run it via the tini init daemon.
ENV TINI_VERSION v0.18.0
Expand Down
4 changes: 2 additions & 2 deletions typha/docker-image/Dockerfile.arm64
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@
# limitations under the License.

ARG QEMU_IMAGE=calico/go-build:latest
FROM ${QEMU_IMAGE} as qemu
FROM ${QEMU_IMAGE} AS qemu

FROM arm64v8/debian:9.8-slim as base
FROM arm64v8/debian:9.8-slim AS base
MAINTAINER Shaun Crampton <shaun@tigera.io>

# Enable non-native builds of this image on an amd64 hosts.
Expand Down
4 changes: 2 additions & 2 deletions typha/docker-image/Dockerfile.ppc64le
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@
# limitations under the License.

ARG QEMU_IMAGE=calico/go-build:latest
FROM ${QEMU_IMAGE} as qemu
FROM ${QEMU_IMAGE} AS qemu

FROM ppc64le/debian:9.8-slim as base
FROM ppc64le/debian:9.8-slim AS base
MAINTAINER Shaun Crampton <shaun@tigera.io>

# Enable non-native builds of this image on an amd64 hosts.
Expand Down
4 changes: 2 additions & 2 deletions typha/docker-image/Dockerfile.s390x
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@

ARG QEMU_IMAGE=calico/go-build:latest

FROM ${QEMU_IMAGE} as qemu
FROM s390x/debian:9.8-slim as base
FROM ${QEMU_IMAGE} AS qemu
FROM s390x/debian:9.8-slim AS base
MAINTAINER LoZ Open Source Ecosystem (https://www.ibm.com/developerworks/community/groups/community/lozopensource)

# Enable non-native builds of this image on an amd64 hosts.
Expand Down

0 comments on commit d3157f6

Please sign in to comment.