Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bpftool to v7.4 #8880

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

mazdakn
Copy link
Member

@mazdakn mazdakn commented Jun 4, 2024

Description

Update bpftool from v5.3 to v7.4 to fix this GH issue: #8856

PR to update Calico bpftool image: projectcalico/bpftool#8

Related issues/PRs

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Upgrade bpftool to v7.4 to fix the issue of loading XDP programs in iptables data plane that happens in few distributions.

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

@marvin-tigera marvin-tigera added this to the Calico v3.29.0 milestone Jun 4, 2024
@marvin-tigera marvin-tigera added release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels Jun 4, 2024
@hjiawei
Copy link
Contributor

hjiawei commented Jun 12, 2024

Shall we do a calico/go-build bpftool update as well once this change is merged?

@mazdakn
Copy link
Member Author

mazdakn commented Jun 13, 2024

@hjiawei this change fixes the issue for amd64 and arm64, but the repository does not release the binary for other archs. Now I am trying to compile the source. WIP PR: projectcalico/bpftool#8

@mazdakn mazdakn changed the title [WIP] Upgrade bpftool Upgrade bpftool to v7.4 Jun 14, 2024
@mazdakn mazdakn marked this pull request as ready for review June 14, 2024 22:03
@mazdakn mazdakn requested a review from a team as a code owner June 14, 2024 22:03
@mazdakn mazdakn added docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact and removed docs-pr-required Change is not yet documented release-note-required Change has user-facing impact (no matter how small) labels Jun 14, 2024
@marvin-tigera marvin-tigera added release-note-required Change has user-facing impact (no matter how small) and removed release-note-not-required Change has no user-facing impact labels Jun 14, 2024
@mazdakn mazdakn added cherry-pick-candidate release-note-not-required Change has no user-facing impact and removed release-note-required Change has user-facing impact (no matter how small) labels Jun 18, 2024
@mazdakn mazdakn added release-note-required Change has user-facing impact (no matter how small) and removed release-note-not-required Change has no user-facing impact labels Jun 25, 2024
@tomastigera tomastigera merged commit 11810ab into projectcalico:master Jun 25, 2024
1 of 2 checks passed
@mazdakn mazdakn deleted the fix-iptables-xdp branch June 25, 2024 21:22
mazdakn pushed a commit to mazdakn/calico that referenced this pull request Jun 25, 2024
mazdakn pushed a commit to mazdakn/calico that referenced this pull request Jun 25, 2024
caseydavenport pushed a commit that referenced this pull request Jun 26, 2024
Upgrade bpftool to v7.4

Co-authored-by: Tomas Hruby <49207409+tomastigera@users.noreply.github.com>
caseydavenport pushed a commit that referenced this pull request Jun 26, 2024
Upgrade bpftool to v7.4

Co-authored-by: Tomas Hruby <49207409+tomastigera@users.noreply.github.com>
@mazdakn mazdakn added cherry-pick-completed PR has been cherry-picked and removed cherry-pick-candidate labels Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-completed PR has been cherry-picked docs-not-required Docs not required for this change release-note-required Change has user-facing impact (no matter how small)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants