Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecations in yaml lint workflow #8905

Merged
merged 5 commits into from
Jul 5, 2024

Conversation

danudey
Copy link
Contributor

@danudey danudey commented Jun 12, 2024

No description provided.

@danudey danudey requested a review from a team as a code owner June 12, 2024 20:13
@danudey danudey added docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact labels Jun 12, 2024
@danudey danudey self-assigned this Jun 12, 2024
@marvin-tigera marvin-tigera added this to the Calico v3.27.4 milestone Jun 12, 2024
@matthewdupre
Copy link
Member

@danudey What's the right way to check this is good? The lint CI run on the PR seems happy and I'm comfortable the 2 failures in the main CI are unrelated.

@danudey danudey force-pushed the dfox_update_yamllint_v3.27 branch from 7ff9094 to c58bf1c Compare July 3, 2024 16:51
@danudey
Copy link
Contributor Author

danudey commented Jul 3, 2024

@danudey What's the right way to check this is good? The lint CI run on the PR seems happy and I'm comfortable the 2 failures in the main CI are unrelated.

I've compared the changed YAML files with relevant parsers (yq being the main one), and the results are identical (I actually generated the updated files via yq). At this point our only warnings are line length and missing doc start, which I think is a good place to be.

I'd love to expand this out to lint other yaml files, etc., but for now I'm happy leaving it here and seeing how it plays going forward.

* Fix indentation
* Restrict the job to specific files to avoid confusion
* Add some useful commenting
@danudey danudey merged commit bb4f8e2 into release-v3.27 Jul 5, 2024
2 of 3 checks passed
@danudey danudey deleted the dfox_update_yamllint_v3.27 branch July 5, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants